-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .gitignore creation to hz init #681
Conversation
fs.appendFileSync( | ||
'.gitignore', | ||
`rethinkdb_data | ||
**/*.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What generates logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm
sometimes I believe? Specifically, npm-debug.log I've seen before.
Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions. cli/src/init.js, line 238 [r1] (raw file):
This will add leading spaces to all but the first line, due to the indentation inside the backticks. Comments from Reviewable |
Made slight indentation change |
Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions. cli/src/init.js, line 238 [r1] (raw file):
|
👍 |
Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Satisfies #454
This change is