Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore creation to hz init #681

Merged
merged 3 commits into from
Jul 28, 2016

Conversation

dalanmiller
Copy link
Contributor

@dalanmiller dalanmiller commented Jul 28, 2016

Satisfies #454

This change is Reviewable

fs.appendFileSync(
'.gitignore',
`rethinkdb_data
**/*.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What generates logs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm sometimes I believe? Specifically, npm-debug.log I've seen before.

@deontologician
Copy link
Contributor

deontologician commented Jul 28, 2016

:lgtm:

@encryptio
Copy link
Contributor

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


cli/src/init.js, line 238 [r1] (raw file):

      **/*.log
      .hz/secrets.toml
      `,

This will add leading spaces to all but the first line, due to the indentation inside the backticks.


Comments from Reviewable

@deontologician
Copy link
Contributor

Made slight indentation change

@dalanmiller
Copy link
Contributor Author

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.


cli/src/init.js, line 238 [r1] (raw file):

Previously, encryptio (Chris Kastorff) wrote…

This will add leading spaces to all but the first line, due to the indentation inside the backticks.

Done.

Comments from Reviewable

@dalanmiller
Copy link
Contributor Author

👍

@encryptio
Copy link
Contributor

:lgtm:


Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants