Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yamllint installation #28

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix yamllint installation #28

merged 1 commit into from
Jul 18, 2023

Conversation

st0ck
Copy link
Contributor

@st0ck st0ck commented Jul 18, 2023

yamllint check started to fail on Jul 17, 2023. It’s failing at the stage of installation.
pyyaml v5.4 causes the issue. See more: yaml/pyyaml#601

That's a temporary fix that tags an older version of the pyyaml.

Fixes #27

@st0ck
Copy link
Contributor Author

st0ck commented Jul 18, 2023

@haya14busa @shogo82148 could you review the changes, please?

@st0ck
Copy link
Contributor Author

st0ck commented Jul 18, 2023

nevermind, looks like a temporary fix for pyyaml is already merged yaml/pyyaml#702

@shogo82148 shogo82148 merged commit 49fe172 into reviewdog:master Jul 18, 2023
2 checks passed
@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v1.7.2 Changes:v1.7.1...v1.7.2

@review-dog
Copy link
Member

Hi, @st0ck! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

@javierjulio
Copy link

With what @st0ck linked to, they released 6.0.1 yesterday yaml/pyyaml#702 (comment) so would that resolve it rather than downgrading here?

acobaugh added a commit to Updater/action-yamllint that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.7.1 action broken PyYAML Dependency
4 participants