Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): Update breaking change in the upload artifact to include hidden files #13

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

stairsj
Copy link
Contributor

@stairsj stairsj commented Sep 3, 2024

Description of change

Code coverage started failing with errors of missing files. Turns out on Sept 2nd 2024 they released a breaking change to the v4 version of our upload-artifacts action that stopped loading hidden files.

The simplecov step started failing

Run aki77/simplecov-report-action@7fd5fa551dd583dd437a11c640b2a1cf23d6cdaa
Error: Cannot find module '/home/runner/work/nucleus/nucleus/app/coverage/.last_run.json'
Require stack:
- /home/runner/work/_actions/aki77/simplecov-report-action/7fd5fa551dd583dd437a11c[6](https://github.com/rewindio/nucleus/actions/runs/10682221080/job/29609865315#step:3:7)40b2a1cf23d6cdaa/dist/index.js

actions/upload-artifact#602

Bumped the rubocop gems due to this error.

Testing Performed

This PR since the code coverage was run successfully.

Copy link

github-actions bot commented Sep 3, 2024

Simplecov Report

Covered Threshold
100% 100%

Signed-off-by: Jon Stairs <jonathan.stairs@rewind.com>
Gemfile.lock Outdated Show resolved Hide resolved
Signed-off-by: Jon Stairs <jonathan.stairs@rewind.com>
@stairsj stairsj merged commit 016d910 into main Sep 3, 2024
7 checks passed
@stairsj stairsj deleted the chore/stairsj/update-coverage-upload branch September 3, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants