Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ava ci #23

Merged
merged 5 commits into from
Feb 14, 2024
Merged

fix: ava ci #23

merged 5 commits into from
Feb 14, 2024

Conversation

rexfordessilfie
Copy link
Owner

@rexfordessilfie rexfordessilfie commented Feb 14, 2024

Overview

The testing pipeline began to fail following the release of new node version 18.19. This version included breaking changes such as deprecating the experimental --loader flag which was being relied on in the configuration for ava tests.

Specifically, we were supplying the node arguments --loader=tsx to compile .ts files to JS before executing tests.

With the removal of this flag, tsx package has since been updated here (privatenumber/tsx#422) to support usage via the --import flag instead.

Furthermore, based on inspiration from this issue(TypeStrong/ts-node#935 (comment)) and digging through ava docs, I was inspired to update the extensions configuration to just specify "ts".

Finally since --import is not supported by Node 16, which has also reached EOL, I have updated the CI workflow to test for 18 and 20.

Finally, updated the pnpm version in the workflow to get past this issue(pnpm/pnpm#6424)

@rexfordessilfie rexfordessilfie marked this pull request as ready for review February 14, 2024 06:03
@rexfordessilfie rexfordessilfie merged commit 43bc1dd into main Feb 14, 2024
2 checks passed
@rexfordessilfie rexfordessilfie deleted the fix-ava-ci branch February 16, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant