Try reserving less ram... #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
frozencemetery
approved these changes
Aug 8, 2022
In 005a0aa, we switched from reserving one quarter of the available free memory to three quarters. Apparently this has some unfortunate side-affects for some workloads, and has negatively effected chainloading[0] as well as Fedora CoreOS[1]. This patch changes it to reserve /half/ of available memory, in hopes that this is a working compromise. [0] https://bugzilla.redhat.com/show_bug.cgi?id=2115202 [1] coreos/fedora-coreos-tracker#1271 Signed-off-by: Peter Jones <pjones@redhat.com>
frozencemetery
force-pushed
the
reserve-less-memory
branch
from
37bc492
to
8739990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 005a0aa, we switched from reserving
one quarter of the available free memory to three quarters. Apparently
this has some unfortunate side-affects for some workloads, and has
negatively effected chainloading[0] as well as Fedora CoreOS[1].
This patch changes it to reserve /half/ of available memory, in hopes
that this is a working compromise.
[0] https://bugzilla.redhat.com/show_bug.cgi?id=2115202
[1] coreos/fedora-coreos-tracker#1271
Signed-off-by: Peter Jones pjones@redhat.com