Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated Manifest.writeTo(Writer) and use Manifest.writeTo(Object) instead #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop using deprecated Manifest.writeTo(Writer) and use Manifest.writeTo(Object) instead #32

wants to merge 1 commit into from

Conversation

olisikh
Copy link

@olisikh olisikh commented Jun 30, 2017

In Gradle 4.0 Manifest.writeTo(Writer) will be removed, to make it compatible, Manifest.writeTo(Object) needs to be used

…teTo(Object) instead

In Gradle 4.0 Manifest.writeTo(Writer) will be removed, to make it compatible, Manifest.writeTo(Object) needs to be used
@olisikh olisikh changed the title Stop using deprecated Manifest.writeTo(Writer) and using Manifest.writeTo(Object) instead Stop using deprecated Manifest.writeTo(Writer) and use Manifest.writeTo(Object) instead Jun 30, 2017
@sebastienvermeille
Copy link

Please merge this we are blocked with version 4

@olisikh
Copy link
Author

olisikh commented Jul 6, 2017

Looks like the plugin owner doesn't maintain the project any longer :(

@sebastienvermeille
Copy link

sebastienvermeille commented Jul 6, 2017

@alisiikh I contacted him on twitter if we don't get any response should we do a fork of it and maintain it ?

@martin-linha
Copy link

+1
Please merge this.

@sebastienvermeille
Copy link

I wrote him on twitter no reaction. Maybe he is on holidays

Copy link

@nathanalderson nathanalderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@martin-linha
Copy link

Please release it. Thanks!

@LeviticusMB
Copy link

We have a fork here for those interested.

@nsoft
Copy link

nsoft commented Aug 12, 2017

Forking is a good first step, but are you publishing it as a plugin in the gradle plugin repository? A link to that would be more helpful (I didn't find it with their search).

@LeviticusMB
Copy link

Yes I will publish. Need a couple of days though.

@LeviticusMB
Copy link

See

@nsoft
Copy link

nsoft commented Apr 15, 2018

nice that you published it, but I see you aren't enabling issue reporting on your github repo :( I suppose that's you being upfront about not wanting to maintain it, but the floundering continues the next time something breaks... sigh

@LeviticusMB
Copy link

Well ... why not. Issue reporting has been enabled.

@nsoft
Copy link

nsoft commented Apr 17, 2018

Cool, that's encouraging :) thanks

@nros
Copy link

nros commented Jun 30, 2018

fixes issue #34, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants