Checking for int.MinValue separately. #471
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this library with Xamarin. When updating Visual Studio this library broke, but only when building for a release package. When debugging everything worked fine.
After adding extra logging we found that
t1.GetField("MinValue")
resulting innull
and thusisMin1
was false. When setting an EndDate it complained that "Both COUNT and UNTIL cannot be supplied together; they are mutually exclusive."As
CheckMutuallyExclusive
is only used once and count is always obj1 I just added a check for int.MinValue if obj1 is an int.I cannot find why this behaviour changed. I also don't know whether it is the xamarin compiler, the .net framework or the c# language. (We forced c# to 7.0, so the last one shouldn't be the problem.)
For now this fixes our problem, but I can understand it when you don't really like the solution and I'm willing to discuss a better solution.