Fix multiple files upload in the same time with tempfile handler. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix multiple files upload in the same time with temp files handler.
Fix multiple file upload in the same time
Fix dir value expression, which probable came from some old version: const dir = options.tempFileDir || process.cwd() + '/tmp/'; insted of const dir = __dirname + (options.tempFileDir || '/tmp/');
Use path module to deal with paths to temp directory and temp files.
Change description about necessary trailing slashed in temporary files path.
|
Looks good @RomanBurunkov thank you! |
RomanBurunkov
added a commit
to RomanBurunkov/express-fileupload
that referenced
this pull request
Feb 11, 2019
Merge pull request richardgirges#116 from RomanBurunkov/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #113
It creates seaprate variable for write stream for each file upload, instead of using one shared.