This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
X-Address Encoding in Issued Currencies #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliot
approved these changes
Dec 11, 2020
ledhed2222
pushed a commit
that referenced
this pull request
Oct 13, 2021
* feat(account): allow issued currency to use x-address
intelliot
referenced
this pull request
in XRPLF/xrpl.js
Oct 18, 2023
* feat(account): allow issued currency to use x-address
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Handle the case when issued currencies have an X-address in the issuer.
Context of Change
We handle the two cases where X addresses can have destination tags in
STObject. For the rest of theAccountIDs, if we receive an X address then it cannot have a tag associated with it. This PR implements this functionality in theAccountID::fromBase58Type of Change
Test Plan
Adds two tests to test this functionality