Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support vmv.v.v and vmerge.vvm for bf16 with zvfbfmin #353

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support vmv.v.v and vmerge.vvm for bf16 with zvfbfmin #353

wants to merge 3 commits into from

Conversation

4vtomat
Copy link
Collaborator

@4vtomat 4vtomat commented Aug 2, 2024

Resolve: #349

kito-cheng
kito-cheng reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@kito-cheng kito-cheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bf16 should able to support vmv.v.f as well, I mean that could hold in FPR in theory (both for w/ and w/o zfbhmin)

@4vtomat
Copy link
Collaborator Author

4vtomat commented Sep 10, 2024

bf16 should able to support vmv.v.f as well, I mean that could hold in FPR in theory (both for w/ and w/o zfbhmin)

Updated!

kito-cheng
kito-cheng approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure it's merge-able before you click merge :P

@jerryzj
Copy link
Collaborator

jerryzj commented Sep 25, 2024

Please use make yapf-format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kito-cheng kito-cheng kito-cheng approved these changes

@rofirrim rofirrim Awaiting requested review from rofirrim

@eopXD eopXD Awaiting requested review from eopXD

@topperc topperc Awaiting requested review from topperc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should bf16 vmv.v.v and vmerge.vvm be supported with Zvfbfmin?
3 participants
@4vtomat @jerryzj @kito-cheng