-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zip and Unzip descriptions are reversed #1632
Comments
@kdockser I'm having deja vu; I thought we already resolved this. It looks like the SAIL code is correct but the descriptions are swapped. Can you confirm and either file a PR or let me know so I can do so? |
As I recall, no one was sure how to modify and rebuild the scalar crypto spec, so fixing errors like this kept getting put off. |
Not only the description but also the encoding is incorrect, wording should be the same as in the ratified paper ( https://github.com/riscv/riscv-crypto/releases/download/v1.0.1-scalar/riscv-crypto-spec-scalar-v1.0.1.pdf ) |
@pierrecolim could you file a PR? |
no sorry, i never used github, i only have an account to open issues and comment |
Something went wrong when these specs were integrated into the main ISA manual. This PR restores the definitions of these instructions to the ratified ones. Resolves #1632
OK, done. LMK if you spot any further issues @kdockser @pierrecolim #1635 |
As reported on reddit "In the standard page 267 the description of the zip instruction doesn't match the operation, which is correct?" by PColim in the risc-v subreddit. This applies to the 20240811 published version of unpriv.
The text was updated successfully, but these errors were encountered: