Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run root Docker as the current user #1647

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Sep 25, 2024

Reapplication of 3539eff but this time we only add the --user argument for root Docker. Rootless Docker behaves the same as Podman and doesn't need the --user flag; in fact it breaks builds if you add it.

I also added a comment for the :z flag.

Reapplication of 3539eff but this time we only add the `--user` argument for root Docker. Rootless Docker behaves the same as Podman and doesn't need the `--user` flag; in fact it breaks builds if you add it.

I also added a comment for the `:z` flag.
@Timmmm
Copy link
Contributor Author

Timmmm commented Sep 25, 2024

IMO a better solution than messing around with Docker/Podman is Apptainer, which is explicitly designed for this use case and takes care of exposing mounts etc. for you. Unfortunately people are unlikely to have it installed already so we're probably in an "everyone uses shitty Bash scripts because Bash is already there" sort of situation. :-/

@aswaterman
Copy link
Member

FWIW, this version works on my Mac.

@wmat
Copy link
Collaborator

wmat commented Sep 25, 2024

This fix allows me to build locally on Fedora again successfully. I'm interested to see if the create release workflow succeeds on GH though. I'm going to merge this now to find out.

@wmat wmat merged commit 9648e5e into riscv:main Sep 25, 2024
2 checks passed
@wmat
Copy link
Collaborator

wmat commented Sep 25, 2024

The Release new ISA When merging a PR still fails. I recognize why this is happening. We'll try to figure out how to fix this.

@Timmmm
Copy link
Contributor Author

Timmmm commented Sep 25, 2024

It won't pass because it's running from my fork.

If you run it manually for master it should work though. I think the configuration needs to be changed a bit, I'm not a GitHub actions pro though....

@wmat
Copy link
Collaborator

wmat commented Sep 25, 2024

I fixed up the workflow and it's working as it should now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants