-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rw_actor_splits
#18746
feat: add rw_actor_splits
#18746
Conversation
…ate meta_client Signed-off-by: Shanicky Chen <peng@risingwave-labs.com>
… add `From` impl; simplify `read_rw_actor_splits`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM. Thanks
Can we add some tests btw? (Perhaps we can do sth like select count(*) group by source_id
to avoid nondeterministic results including actor ids)
.remove(&(actor_id as _)) | ||
.unwrap_or_default() | ||
.into_iter() | ||
.map(move |split| list_actor_splits_response::ActorSplit { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a column type
to show whether it's source fragment or backfill fragment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to differentiate between the backfill source and the downstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Maybe this need a release note btw |
…to and rw_actor_splits.rs
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This pull request adds the
rw_actor_splits
system table, which provides the columnsactor_id
,split_id
,source_id
, andfragment_id
.Checklist
./risedev check
(or alias,./risedev c
)