feat: ban ALTER SOURCE for shared source, and refine all ALTER clauses #18750
+101
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
9 tasks
xxchan
force-pushed
the
09-27-feat_ban_alter_source_for_shared_source
branch
from
155fc55
to
6fe0e51
Compare
xxchan
force-pushed
the
09-27-feat_ban_alter_source_for_shared_source
branch
from
6fe0e51
to
a929df8
Compare
xxchan
changed the base branch from
main
to
09-27-refactor_unify_duplicated_alter___name_methods
Base automatically changed from
09-27-refactor_unify_duplicated_alter___name_methods
to
main
September 29, 2024 03:04
also examined all ALTER clauses for shared source Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
force-pushed
the
09-27-feat_ban_alter_source_for_shared_source
branch
from
a929df8
to
6209627
Compare
xxchan
changed the title
tabVersion
approved these changes
Oct 2, 2024
| @@ -228,6 +228,9 @@ pub async fn handle_alter_source_with_sr( | |||
| ) | |||
| .into()); | |||
| }; | |||
| if source.info.is_shared() { | |||
| bail_not_implemented!(issue = 123, "alter shared source"); | |||
There was a problem hiding this comment.
is 123 just a placeholder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
feat: ban alter source for shared source
also examined all ALTER clauses for shared source
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.