multiple bugs with additionalProperties component

[aerfio]

Prerequisites

• I have read the documentation;
• In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description

• There is no option to remove key-value pair once it's added
• Key changes name when doubleclicked
• Key-value pair also sometimes change position, when you add more pairs, change their keys and doubleclick again

Steps to Reproduce

1. Loot at provided jsfiddle
2. Doubleclick "newKey Key"
3. It changes name to "newKey-1 Key"
4. Doubleclick again
5. "newKey-1-1 Key"
6. add one more pair
7. click key again
8. they should change their order

https://jsfiddle.net/aerfio/mynuxdc4/

Expected behavior

I expect to have option to remove once added key-value pair and to preserve order of those pairs.

Actual behavior

No "remove/delete/X" button, ordering is not preserved

Version

1.0.6

Related: #228

[aerfio]

@christianclent, can you have a look at this? Are working on this, can we help somehow?

[domharrington]

Some other issues I've discovered:

• When your cursor is inside the "key" input, pressing tab has the same effect of renaming to append -1 to the name.
• Key changes dont apply until focus on the input is lost. Could this happen in real time?
• Deleting all of the characters inside of the value results in an unrecoverable error:

Unsupported field schema for field root_newKey: Unknown field type null.

{
  "type": "null",
  "__additional_property": true,
  "format": ""
}

[domharrington]

It would also be great to get an additional class name here so this can be styled:
https://github.com/mozilla-services/react-jsonschema-form/blob/0ac0da7eb3fb99bb76017572dd10ef7a11ffadcd/src/components/fields/SchemaField.js#L133-L134

[loganvolkers]

Wow, so many bugs with additional properties.

This should have been released on an alpha branch, as it's clearly early functionality that create backwards incompatible renderings of forms and functionality.

[glasserc]

#1123 is listed as fixing all these issues. Please try it and let me know.

additionalProperties was marked as "preliminary" in #1021 and I didn't expect it to be perfect, but as forms don't get the functionality unless they include an additionalProperties field, it seemed like it was opt-in and not a problem to just release. Sorry if the preliminary nature of the feature wasn't communicated clearly. However, I don't think "releasing it on an alpha branch" would have helped since my impression is that people only want to use rjsf via the latest npm release.