Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-value pair in additional properties retains order when edited #1101

Merged
merged 3 commits into from
Dec 21, 2018

Conversation

aerfio
Copy link
Contributor

@aerfio aerfio commented Dec 7, 2018

Reasons for making this change

When you change key it shows on the bottom of the list, instead of keeping its place, keeping the order of key-value pairs.

If this is related to existing tickets, include links to them as well.

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Solves two things of #1099

@aerfio aerfio changed the title Key-value pair in additional properties retain order when edited Key-value pair in additional properties retains order when edited Dec 20, 2018
@aerfio
Copy link
Contributor Author

aerfio commented Dec 20, 2018

@glasserc @edi9999 Any comment on this and/or related issue?

@edi9999
Copy link
Collaborator

edi9999 commented Dec 20, 2018

Can you add a test case in the same form as https://github.com/mozilla-services/react-jsonschema-form/blob/master/test/ObjectField_test.js#L582 that fails before your patch, and succeeds afterwards ?

@aerfio
Copy link
Contributor Author

aerfio commented Dec 21, 2018

@edi9999 Done, those tests fail on master and succeed here

@edi9999
Copy link
Collaborator

edi9999 commented Dec 21, 2018

Great , merging !

@edi9999 edi9999 merged commit ae9e58d into rjsf-team:master Dec 21, 2018
@aerfio
Copy link
Contributor Author

aerfio commented Jan 2, 2019

@edi9999 When do you guys plan to realease 1.0.7? Do you have it scheduled?

@aerfio aerfio deleted the rightOrder branch January 2, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants