-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #824 #1147
Fixes #824 #1147
Conversation
Just a regex tweak. |
Thanks @jorgerobles, good work 😀-- can you add a test as you did in https://github.com/mozilla-services/react-jsonschema-form/pull/967/files? Probably it should involve making a custom widget which collects only the data uri, not the name. |
Really needed? If so I will do on weekend
El lun., 21 ene. 2019 19:16, Ashwin Ramaswami <notifications@github.com>
escribió:
… Thanks @jorgerobles <https://github.com/jorgerobles>, good work 😀-- can
you add a test as you did in
https://github.com/mozilla-services/react-jsonschema-form/pull/967/files?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1147 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABoIYF6vyHy-8DbMFK1aLCCrYu0Xyiz-ks5vFgQIgaJpZM4aLRY0>
.
|
It would be better indeed to have a regression test. |
test/validate_test.js
Outdated
errors = result.errors; | ||
}); | ||
|
||
it("Both should be fine", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test -- don't mean to be nitpicky, but it would really be great and cleaner if you could have separate it
functions for the dataUrlWithName and a test case for dataUrlWithoutName.
Thanks! |
* 'master' of github.com:KeroVieux/react-jsonschema-form: updated replace submit button paragraph tag with div (rjsf-team#766) Fixes rjsf-team#824 (rjsf-team#1147) Fix bug where matching anyOf branch is not selected correctly (rjsf-team#1129) Document a gotcha with `additionalProperties` (rjsf-team#1149) doc: add permalinks and fix internal hyperlinks in documentation doc: add doc build instructions, update PR/issue templates with doc links Add onBlur and onFocus events for radio and checkbox widgets (rjsf-team#1143) add ui:help tips (rjsf-team#1145) doc: fix browserstack logo size docs: remove docs from README and link to readthedocs rjsf-team#1138 doc: organize docs into separate files rjsf-team#1138 doc: add browserstack logo rjsf-team#990 Add test and update documentation for using anyOf inside array items (rjsf-team#1131) # Conflicts: # src/components/Form.js
Reasons for making this change
See Issue #824, made name not required.
Checklist
npm run cs-format
on my branch to conform my code to prettier coding style