Fix #385: Avoid dynamic requires.

[n1k0]

Refs #385

@dulguun0225 could you please confirm this would solve your issue?

@olzraiti I'd love a review from you on this.

[olzraiti]

Looks all good to me!

[n1k0]

In d2b3792 I avoid requiring on every call, which might save us a few nanoseconds.

Now waiting for @dulguun0225's feedback

[dulguun0225]

Yes, it would.

[n1k0]

Released along v0.41.2.

[DanialK]

Hey guys,
I have just tried v0.41.2 and noticed that the object SchemaField.defaultProps.registry, is undefined. Basically as you can see in the logs, the first couple of times the getDefaultRegistry gets called it's returning undefined which is being set to the SchemaField.defaultProps.registry when doing

SchemaField.defaultProps = {
  registry: getDefaultRegistry()
};

Just to give you some context to my issue, i'm using a customised version of Kinto/formbuilder and here is where the problem occurred.

I currently have no idea why this is happening but would appreciate if you guys had any idea!
Cheers

[DanialK]

Hi @n1k0 ,

The issue above is not fixed yet and is due to cyclical imports because fields and widgets in defaultRegistry all call the getDefaultRegistry

SchemaField.defaultProps = {
  uiSchema: {},
  errorSchema: {},
  idSchema: {},
  registry: getDefaultRegistry(),  <-------
  disabled: false,
  readonly: false,
  autofocus: false,
};

// SchemaField.js
const defaultRegistry = {
  fields: require("./components/fields").default,
  widgets: require("./components/widgets").default,
  definitions: {},
  formContext: {}
};

export function getDefaultRegistry() {
  return defaultRegistry;
}

// utils.js
but then the defaultRegistry is not even loaded at that point so it returns undefined.
defaultRegistry codes should be moved to a seperate file that can be imported without causing this cyclic dependency issue.

Thanks