Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/integrate esys #11

Merged
merged 73 commits into from
Jun 15, 2023
Merged

Features/integrate esys #11

merged 73 commits into from
Jun 15, 2023

Conversation

MaGering
Copy link
Collaborator

@MaGering MaGering commented Nov 1, 2022

Resolves #3

With this PR it is possible to build, optimize and postprocess an energy system with oemof-B3 based scripts and tools in digipipe.
optimizing and postprocessing serves as a test for the correct set up of the energy system and can be either removed or used as tests in digiplan.

Before merging into dev-branch, please make sure that

  • if data flow was adjusted: data pipeline run finishes successfully.
  • new and adjusted code is formated using black and isort. -> After Features/add pre commit  #64 is merged
  • the CHANGELOG.rst was updated.
  • the docs were updated. -> ESYS.md file

@MaGering MaGering self-assigned this Nov 1, 2022
@MaGering MaGering requested a review from nesnoj November 1, 2022 11:11
@nesnoj
Copy link
Member

nesnoj commented Dec 13, 2022

Log

  • raw data stored in /store/datasets/esys_raw/ (dummy data as input for now)
    • data sources are defined and name mapping takes place in config, e.g. in /store/appdata/esys/config.yml, e.g.
datasets:
  wind_feedin:
    file: "timeseries.csv"
    column: "xxx"
    name_esys: "abw-wind-"
  • preprocessed in /store/appdata/esys/ with some subdir such as .TEMPLATE with esys template files (which is committed)

@MaGering
Copy link
Collaborator Author

Please rename raw/esys_costs_efficiencies to raw/dea_costs_efficiencies as the dir name in raw should start with the source. If there're multiple sources, we might just name it raw/costs_efficiencies. Cheers

Thanks for the hint. Done with commit 91b3c03.

And I tend to rename the dir snakemake_rules to just rules

For now, I would keep the name because it is named the same as the directory in oemof-B3. If for another repo should be built on the same structure, the mapping of what comes from what would be easier.

@MaGering
Copy link
Collaborator Author

Further notes/tasks for the future:

* Refactor structure for neat integration (best fit into pipeline's structure **VS** reusability in future projects)

* Merge/check for redundant functions from pipeline and esys; functions from esys which could be useful in the entire pipeline (e.g. timing)

True. I created an issue for this: #69

Copy link
Member

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaGering!
snakemake -j1 make_esys_appdata works out perfectly.
I adjusted some small things, e.g. integrated the esys docs into the mail docs, see commits above.
Merge if you dare! :)

@MaGering MaGering merged commit 2e99ac5 into dev Jun 15, 2023
@MaGering MaGering deleted the features/integrate-esys branch June 15, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate esys into digipipe
2 participants