Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to directory #72

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

jarmillemich
Copy link

Copy link
Owner

@rlane rlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out own my own AI crate and got some errors:

rustc failed: error[E0432]: unresolved import `crate::cobra`
    --> /tmp/oort-ai/ai/src/user.rs:3882:12
     |
3882 | use crate::cobra::*;
     |            ^^^^^
     |            |
     |            unresolved import
     |            help: a similar path exists: `crate::user::cobra`

error[E0432]: unresolved import `test_log`
    --> /tmp/oort-ai/ai/src/user.rs:3884:5
     |
3884 | use test_log::test;
     |     ^^^^^^^^ use of undeclared crate or module `test_log`

error: cannot determine resolution for the attribute macro `test`
    --> /tmp/oort-ai/ai/src/user.rs:3886:3
     |
3886 | #[test]
     |   ^^^^
     |
     = note: import resolution is stuck, try simplifying macro imports

I'll solve the first one by moving the user code into the root of the crate in the compiler service. I guess I can live without test_log.

It would be nice if the file selector showed all files vs just the ones that start with "ai_".

@jarmillemich
Copy link
Author

Removed the special cases (lib.rs and ai_[scenario]) and the ai_* restrictions
lib.rs is still a little special as it gets rewritten, but not in the UI

@jarmillemich jarmillemich marked this pull request as ready for review November 17, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants