Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Install-PACertificate #159

Closed
joshooaj opened this issue Jul 14, 2019 · 5 comments
Closed

Feature Request: Install-PACertificate #159

joshooaj opened this issue Jul 14, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@joshooaj
Copy link
Contributor

The New-PACertificate cmdlet with -Install is great, but if you're manually running the commands and forget the -Install switch, you have to either find/install the pfx manually on Windows, or rerun New-PACertificate.

I'd like to be able to call Install-PACertificate and if I supply no parameters, it takes the output of Get-PACertificate and installs the PFX accordingly, or be able to take pacertificate objects from the pipeline.

@rmbolger
Copy link
Owner

I like the idea and I get where the request comes from. The only problem I have with this is that it feels weird to include a function that will only work on Windows. On non Windows machines, I'm trying to decide whether it should throw an error or just a warning and be effectively a no-op.

Would it make sense to include a parameter set that would enable a file copy type install for non-Windows OSes? And in that case, should the option somehow be included with New-PACertificate as well? It's probably easier to stick with the simple case for now.

@rmbolger rmbolger self-assigned this Jul 15, 2019
@rmbolger rmbolger added the enhancement New feature or request label Jul 15, 2019
@joshooaj
Copy link
Contributor Author

I'm not very familiar with non-Windows OS's and the different ways certificates might be handled there. I can understand the hesitancy. In my opinion, the -Install switch already breaks that strict cross-platform approach, but in a way that is really useful for probably most of the user base and unobtrusive for non-Windows users.

Likewise, I think having Install-PACertificate be a no-op with a Write-Warning would be informative to curious non-Windows users, but if there's some work that command could do which makes sense in a non-Windows environment, that'd be even better.

@rmbolger
Copy link
Owner

I agree. Just wanted to roll the idea around in my head to see if it made sense to include more functionality into this.

rmbolger added a commit that referenced this issue Jul 19, 2019
@rmbolger
Copy link
Owner

Ok, Install-PACertificate has been added in the master dev branch. New-PACertificate has also been updated to use it internally as well. Give it a go and see how it works for you. Everything seems to be happy in my tests so far.

@joshooaj
Copy link
Contributor Author

That's awesome, thanks! Hopefully there's a logical way to make that cmdlet cross platform but I'll definitely make use of this on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants