Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyLength not honored on renewal #326

Closed
juliansiebert opened this issue Mar 13, 2021 · 2 comments
Closed

KeyLength not honored on renewal #326

juliansiebert opened this issue Mar 13, 2021 · 2 comments
Assignees
@rmbolger
Labels
bug Something isn't working

Comments

@juliansiebert
Copy link
Contributor

Hi,
on renewing with "Submit-Renewal" the specified keylength of the previous order is ignored and is set back to default "2048".
This fixed it for me: #325

Best regards
Julian
@rmbolger rmbolger self-assigned this Mar 13, 2021
@rmbolger rmbolger added the bug Something isn't working label Mar 13, 2021
@rmbolger
Copy link
Owner

Hi @juliansiebert. Great find! I think this has been broken since the 4.0 release. After looking more closely, I think there might be a couple other places in the code that need fixing as well. Give me a bit to run through some edge cases and we'll get this patched up.

@rmbolger rmbolger mentioned this issue Mar 14, 2021
Merged
rmbolger added a commit that referenced this issue Mar 14, 2021
@rmbolger
Fix New-PACertificate using old order KeyLength when not overridden. (#…
ff78c8e 
…326)
@rmbolger
Copy link
Owner

Ok, I think those changes cover the edge cases I sussed out. I'm gonna try and push this out pretty quick as 4.3.2. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmbolger rmbolger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliansiebert @rmbolger