DNSimple Plugin regression

[dvdgutzmann]

Hi!

In 01c3764 the Write-Debug (https://github.com/rmbolger/Posh-ACME/blame/8236403fff306555f0ec9a7eb7ecf2ed33653d9f/Posh-ACME/Plugins/DNSimple.ps1#L253) was guarded with an if-statement. The Write-Debug was later in ea925c8 replaced with a throw - which now causes our orchestrating code to crash. The condition should be corrected to $_.Exception.Response.StatusCode -ne 404

            if ($_.Exception.Response.StatusCode -ne 404) {
                throw
            }

Thanks! David

[rmbolger]

Hey @dvdgutzmann, thanks for reaching out. Sorry about that. This looks to be a PowerShell 5.1 specific issue I had forgotten was different. The Microsoft.PowerShell.Commands.HttpResponseException that PS 7+ returns does actually have a StatusCode field. But the System.Net.WebException that PS 5.1 returns doesn't.

I should have it fixed shortly.

[rmbolger]

Fix live in 4.23.1

[dvdgutzmann]

Thank you very much - everything is working as expected again. Great response time, by the way. We really appreciate you!

Thanks! David