Merge pull request #1108 from react-native-mapbox-gl/mattijsf/logger-fix

Prevent emitting log events without listeners
rnmapbox · Nov 17, 2020 · d6c8a93 · d6c8a93
2 parents 8863207 + e21ebe8
commit d6c8a93
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/ios/RCTMGL/RCTMGLLogging.m b/ios/RCTMGL/RCTMGLLogging.m
@@ -2,6 +2,10 @@
 
 @import Mapbox;
 
+@interface RCTMGLLogging()
+@property (nonatomic) BOOL hasListeners;
+@end
+
 @implementation RCTMGLLogging
 
 + (id)allocWithZone:(NSZone *)zone {
@@ -37,8 +41,22 @@ + (BOOL)requiresMainQueueSetup
   return @[@"LogEvent"];
 }
 
+- (void)startObserving
+{
+    [super startObserving];
+    self.hasListeners = true;
+}
+
+- (void)stopObserving
+{
+    [super stopObserving];
+    self.hasListeners = false;
+}
+
 - (void)sendLogWithLevel:(MGLLoggingLevel)loggingLevel filePath:(NSString*)filePath line:(NSUInteger)line message:(NSString*)message
 {
+    if (!self.hasListeners) return;
+
     NSString* level = @"n/a";
     switch (loggingLevel) {
     case MGLLoggingLevelInfo: