-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to be consumed without use_frameworks! #714
Conversation
Tested it and it worked on my side. That's really great, I ship it to production :D |
Hi @mfazekas, I also ran this through on our end. This appears to be working. App also ran successfully. |
@mfazekas Thank you for your work on this PR. Very much appreciated!! |
Probably i'd rename the podspec to
|
@mfazekas that sounds good to me. Good and clear. |
ec0eba8
to
f2a1fd6
Compare
Tested and working ! Thanks a lot @mfazekas ! |
This is a possible workaround for
use_frameworks!
If you don't want
use_frameworks!
in your podfile use thepod 'NoUseFrameworks-MapboxMobileEvents' ...
line bellow:Note: you can test this PR with this in your packages.json
"@react-native-mapbox-gl/maps": "mfazekas/maps-1#allow-no-use-frameworks"
See mapbox/mapbox-gl-native-ios#154