Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Triangle Annotator #1285

Closed
2 tasks done
dsaha21 opened this issue Jun 16, 2024 · 4 comments
Closed
2 tasks done

Modified Triangle Annotator #1285

dsaha21 opened this issue Jun 16, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dsaha21
Copy link
Contributor

dsaha21 commented Jun 16, 2024

Search before asking

  • I have searched the Supervision issues and found no similar feature requests.

Description

Upgradation of the triangle above head annotators more prominently

Modified__traiangle_2
Modified_Triangle_1

Use case

The original Triangle Annotator is attached below :-
Original

The modified one might help us to view for a more clear detection.

Additional

My request is to please analyse the modified annotator. If its pleasing and if possible please accept for a PR. Thank You

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@dsaha21 dsaha21 added the enhancement New feature or request label Jun 16, 2024
@LinasKo
Copy link
Collaborator

LinasKo commented Jun 17, 2024

Hi @dsaha21 👋

I like how this looks! Feel free to open a PR for it. Please also include a Colab we can test it in.

Let's make sure the old behaviour is the default, (e.g. if outline_thickness=0 then old triangles are shown).

Are the any other annotators we should add this to?

@dsaha21
Copy link
Contributor Author

dsaha21 commented Jun 17, 2024

Hi @LinasKo,
Thanks for the reply. So I have made changes which are as follows :-

  • If user wants the old triangle, then by default I have kept the outer thickness = 0
  • Otherwise, according to the user's problem use case, they can enter any integer

Including my colab notebook .
Please check and let me know if I can proceed forward with a PR. Thanks

@LinasKo
Copy link
Collaborator

LinasKo commented Jun 18, 2024

This looks great. Let's make a PR :)

One change I'd like to request is to check if this can also be added to sv.DotAnnotator, as it can be just as hard to see: Colab.

@onuralpszr
Copy link
Collaborator

Complete via #1294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants