Modified triangle and dot in annotators-core #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have read the CLA Document and I sign the CLA |
LinasKo
requested changes
Jun 19, 2024
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
LinasKo
approved these changes
Jun 19, 2024
supervision/annotators/core.py
Outdated
| @@ -898,6 +901,7 @@ def annotate( | |||
| else custom_color_lookup, | |||
| ) | |||
| center = (int(xy[detection_idx, 0]), int(xy[detection_idx, 1])) | |||
| cv2.circle(scene, center, self.radius, (0, 0, 0), self.outline_thickness) | |||
There was a problem hiding this comment.
Let's only do this when self.outline_thickness is not 0, just like in the triangle annotator
There was a problem hiding this comment.
Yes @LinasKo, will add a condition statement here. Updating it and submiting.
|
Hi @LinasKo, please check the latest colab notebook These are the final changes. Please let me know about further changes if needed. Thanks |
onuralpszr
force-pushed
the
modify-annotators
branch
2 times, most recently
from
62d0a60
to
272a9cb
Compare
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
onuralpszr
force-pushed
the
modify-annotators
branch
from
4040b4a
to
eec3615
Compare
|
Thank you, @dsaha21 and @onuralpszr! It's great to have such a nice contribution in the repo this quick 😉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding changes as described in the ISSUE
The modifications upon the existing code base might result for a more clear visualisation
Testing
Also adding the colab file for checking and testing.
Thanks.