-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1114 rle support for coco #1163
Conversation
Hi @emsko 👋🏻 Could you accept CLA? Without this, we won't be able to merge your PR. |
Let's split the work on this PR into three parts:
|
@SkalskiP what do you mean by the documentation? Only docstrings or are there additional files? Where to find them? |
…of pixels computed as width*height
Hi @emsko 👋🏻 Thank you very much for dedicating time to this task. In the meantime, I did some light research and found these two videos on YouTube: I compared the results of our implementation of encoding and decoding as well as the execution time. The outcomes are identical; however, the execution time, especially for encoding, is significantly slower. Could we utilize similar tricks to accelerate the encoding process? Here's the Colab I used. https://colab.research.google.com/drive/1Yl3w0B12htaso_VxZ-S2LvvxftiRk-ta?usp=sharing |
Hi @emsko 👋 Do a I couldn't reproduce it as well, but found this issue We'll eventually update the opencv to |
…ion into 1114_RLE_support_for_COCO
… to global __init__.py
Hi @emsko 👋🏻 I just tested your code in Google Colab. Everything seems to be working fine. I also made a few minor changes to the docs, including adding some visualizations. Everything looks great. Many thanks for this work. This is a massive upgrade for COCO dataset support. Working with you was a pleasure. Thank you! 🙏🏻 |
Description
PR adds support for the RLE format in the COCO dataset. Based on #1114 .
It required implementing RLE encode/decode functions and extending the coco_annotations_to_detections/detections_to_coco_annotations functions.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
All functionalities are covered with unit tests + notebook checks the functionalities on larger images.
Any specific deployment considerations
None
Docs
docs/datasets/utils.md