Remove the need to use a singleton to get the ECM pointer #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 2, 2021
diegoferigo
changed the title
diegoferigo
requested review from
traversaro
and removed request for
traversaro
diegoferigo
commented
Aug 3, 2021
traversaro
approved these changes
Aug 3, 2021
Yes, I need gazebosim/gz-sim#953 to be forward ported to upstream's ign-gazebo5 (Edifice) in order to merge the PR to |
|
Forward porting has been done in gazebosim/gz-sim#968. CI is happy, at least to target |
This was referenced Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378 (thanks to gazebosim/gz-sim#936, further details in gazebosim/gz-sim#248) and implements #289.
Requires gazebosim/gz-sim#953. Merged now in upstream, waiting forward porting to Edifice.