Fetching Node metrics directly, not assuming container metrics and pod container lists will always match up #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #15 and #16.
In #15, a segmentation fault occurred. This seems to have been caused by a container being returned from the metrics API that was not returned by the pods API. I've added a nil check to cover that.
In #16, kube-capacity was showing different node totals than kubectl top. I believe that is because I had been summing pod metrics as opposed to fetching node metrics. This misses any util that might be happening outside of the scope of Kubernetes on each node. I've switched around the logic to fetch node metrics and base those numbers off of the numbers returned by the metrics API for nodes themselves.