Add --namespace-labels, --node-labels, and --pod-labels flags #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds new flags to kube-capacitor allowing to filter metrics by labels on namespaces, nodes, and pods. Any set of labels can be provided: ``` kube-capacity -p -u --namespace-labels "mongodb=true" --pod-labels "app=mongodb" ``` Labels are parsed the same way that kubectl parses them. The cluster metrics are all fixed to be the sum of the filtered resources, so the cluster and node metrics do not include metrics from pods that do not fit into the namespace, node or pod labels.
robscott
approved these changes
Feb 23, 2019
|
Glad I could help! I’ve found this utility immensely useful already. |
|
That's great to hear, thanks! These changes just got released as part of 0.2.0 - really cool to have these extra features, thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new flags to kube-capacitor allowing to filter metrics by labels on
namespaces, nodes, and pods.
Any set of labels can be provided:
Labels are parsed the same way that kubectl parses them.
The cluster metrics are all fixed to be the sum of the filtered resources, so the cluster and node metrics
do not include metrics from pods that do not fit into the namespace, node or pod labels.