Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dict.update alter fn is passed a Result #7107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dict.update alter fn is passed a Result #7107

wants to merge 1 commit into from
+618 −618

Conversation

stuarth
Copy link
Sponsor Contributor

@stuarth stuarth commented Sep 20, 2024

bhansconnect
bhansconnect approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@bhansconnect bhansconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting thanks

@bhansconnect
Copy link
Contributor

@Anton-4, any concerns about when we land this? It looks like it will break two examples in other roc-lang repos. Otherwise, it breaks a lot of old advent of code examples, but not too much otherwise in the community.

This was referenced Sep 20, 2024
Open
Open
@Anton-4
Copy link
Collaborator

Anton-4 commented Sep 21, 2024

Thanks for the ping Brendan, I'm going to look at roc-lang/examples#207 first and will come back to this after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhansconnect bhansconnect bhansconnect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuarth @bhansconnect @Anton-4