Merge pull request #767 from pirj/pin-rspec-expectations

Fix support for `rspec-expectations` 3.8.5+

lib/rspec-puppet/matchers.rb

@@ -6,3 +6,4 @@
 require 'rspec-puppet/matchers/dynamic_matchers'
 require 'rspec-puppet/matchers/type_matchers'
 require 'rspec-puppet/matchers/allow_value'
+require 'rspec-puppet/matchers/raise_error'

lib/rspec-puppet/matchers/allow_value.rb

@@ -34,6 +34,14 @@ def failure_message
       def failure_message_when_negated
         "expected that the type alias would not " + description + " but it does"
       end
+
+      def supports_block_expectations
+        true
+      end
+
+      def supports_value_expectations
+        true
+      end
     end
 
     def allow_value(*values)

lib/rspec-puppet/matchers/compile.rb

@@ -78,6 +78,14 @@ def failure_message_when_negated
         end
       end
 
+      def supports_block_expectations
+        true
+      end
+
+      def supports_value_expectations
+        true
+      end
+
       private
       def missing_dependencies?
         retval = false

lib/rspec-puppet/matchers/count_generic.rb

@@ -61,6 +61,14 @@ def failure_message_when_negated
         "expected that the catalogue would not " + description + " but it does"
       end
 
+      def supports_block_expectations
+        true
+      end
+
+      def supports_value_expectations
+        true
+      end
+
     private
 
       def referenced_type(type)

lib/rspec-puppet/matchers/create_generic.rb

@@ -177,6 +177,14 @@ def diffable?
         true
       end
 
+      def supports_block_expectations
+        true
+      end
+
+      def supports_value_expectations
+        true
+      end
+
       def expected
         @errors.map {|e| e.expected if e.respond_to?(:expected)}.compact.join("\n\n")
       end

lib/rspec-puppet/matchers/include_class.rb

@@ -22,6 +22,13 @@ module ManifestMatchers
         end
       end
 
+      def supports_block_expectations
+        true
+      end
+
+      def supports_value_expectations
+        true
+      end
     end
 
   end

lib/rspec-puppet/matchers/raise_error.rb

@@ -0,0 +1,23 @@
+module RSpec::Puppet
+  module GenericMatchers
+    # Due to significant code base depending on the
+    #
+    #     is_expected.to raise_error Puppet::Error
+    #
+    # syntax, and removal of this syntax from RSpec, extend RSpec's built-in
+    # `raise_error` matcher to accept a value target, e.g. a subject defined
+    # as a lambda, e.g.:
+    #
+    #     subject(:catalogue) { lambda { load_catalogue } }
+    #
+    class RaiseError < RSpec::Matchers::BuiltIn::RaiseError
+      def supports_value_expectations?
+        true
+      end
+    end
+
+    def raise_error(*args, &block)
+      RaiseError.new(*args, &block)
+    end
+  end
+end

lib/rspec-puppet/matchers/run.rb

@@ -104,6 +104,14 @@ def description
         end
       end
 
+      def supports_block_expectations
+        true
+      end
+
+      def supports_value_expectations
+        true
+      end
+
       private
       def func_name
         @func_obj.func_name

lib/rspec-puppet/support.rb

@@ -4,6 +4,8 @@
 
 module RSpec::Puppet
   module Support
+    include GenericMatchers
+
     @@cache = RSpec::Puppet::Cache.new
 
     def subject

spec/unit/matchers/raise_error_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+require 'rspec-puppet/support'
+
+describe RSpec::Puppet::GenericMatchers::RaiseError do
+  include RSpec::Puppet::GenericMatchers
+
+  context 'with a failing target' do
+    subject { lambda { fail 'catalogue load failed' } }
+
+    it { should raise_error 'catalogue load failed' }
+  end
+
+  context 'with a passing target' do
+    subject { lambda { } }
+
+    it { should_not raise_error }
+  end
+end