Skip to content

Commit

Permalink
Merge pull request #460 from rollbar/added/python3.12
Browse files Browse the repository at this point in the history
Added support for Python3.12
  • Loading branch information
danielmorell authored Sep 20, 2024
2 parents 46fb38d + 01231cc commit 3a2330f
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 7 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.6, 3.7, 3.8, 3.9, '3.10', 3.11]
python-version: [3.6, 3.7, 3.8, 3.9, '3.10', 3.11, 3.12]
framework:
- NONE
- FLASK_VERSION=1.1.4
Expand Down Expand Up @@ -45,6 +45,8 @@ jobs:
# Django
- framework: DJANGO_VERSION=3.2.25
python-version: 3.11
- framework: DJANGO_VERSION=3.2.25
python-version: 3.12
- framework: DJANGO_VERSION=4.2.15
python-version: 3.6
- framework: DJANGO_VERSION=4.2.15
Expand All @@ -61,6 +63,8 @@ jobs:
# Twisted
- framework: TWISTED_VERSION=20.3.0
python-version: 3.11
- framework: TWISTED_VERSION=20.3.0
python-version: 3.12
- framework: TWISTED_VERSION=22.10.0
python-version: 3.6

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Python notifier for reporting exceptions, errors, and log messages to [Rollbar](

| PyRollbar Version | Python Version Compatibility | Support Level |
|-------------------|-----------------------------------------------|---------------------|
| 1.0.0 | 3.6, 3.7. 3.8, 3.9, 3.10, 3.11 | Full |
| 1.0.0 | 3.6, 3.7. 3.8, 3.9, 3.10, 3.11, 3.12 | Full |
| 0.16.3 | 2.7, 3.4, 3.5, 3.6, 3.7. 3.8, 3.9, 3.10, 3.11 | Security Fixes Only |

#### Support Level Definitions
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ classifiers = [
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3 :: Only",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
Expand Down
2 changes: 1 addition & 1 deletion rollbar/test/fastapi_tests/test_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ async def read_root():
store_current_request.assert_called_once()

scope = store_current_request.call_args[0][0]
self.assertDictContainsSubset(expected_scope, scope)
self.assertEqual(scope, {**expected_scope, **scope})

def test_should_return_current_request(self):
from fastapi import FastAPI
Expand Down
2 changes: 1 addition & 1 deletion rollbar/test/fastapi_tests/test_middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ async def read_root():
store_current_request.assert_called_once()

scope = store_current_request.call_args[0][0]
self.assertDictContainsSubset(expected_scope, scope)
self.assertEqual(scope, {**expected_scope, **scope})

@unittest.skipUnless(
sys.version_info >= (3, 6), 'Global request access is supported in Python 3.6+'
Expand Down
2 changes: 1 addition & 1 deletion rollbar/test/fastapi_tests/test_routing.py
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ async def read_root():
store_current_request.assert_called_once()

scope = store_current_request.call_args[0][0]
self.assertDictContainsSubset(expected_scope, scope)
self.assertEqual(scope, {**expected_scope, **scope})

@unittest.skipUnless(
sys.version_info >= (3, 6), 'Global request access is supported in Python 3.6+'
Expand Down
2 changes: 1 addition & 1 deletion rollbar/test/starlette_tests/test_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ async def root(request):
store_current_request.assert_called_once()

scope = store_current_request.call_args[0][0]
self.assertDictContainsSubset(expected_scope, scope)
self.assertEqual(scope, {**expected_scope, **scope})

def test_should_return_current_request(self):
from starlette.applications import Starlette
Expand Down
2 changes: 1 addition & 1 deletion rollbar/test/starlette_tests/test_middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ async def root(request):
store_current_request.assert_called_once()

scope = store_current_request.call_args[0][0]
self.assertDictContainsSubset(expected_scope, scope)
self.assertEqual(scope, {**expected_scope, **scope})

@unittest.skipUnless(
sys.version_info >= (3, 6), 'Global request access is supported in Python 3.6+'
Expand Down

0 comments on commit 3a2330f

Please sign in to comment.