Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Go module #51

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Make Go module #51

merged 1 commit into from
Feb 20, 2019

Conversation

fgblomqvist
Copy link
Contributor

This just adds the required go.mod file as well as a minor change to one of the tests (since file paths won't necessarily start with the github.com/rollbar path). Understandable if this is not something you want to do (yet) but figured I might as well submit a PR for it (before I submit some other PRs) since the Go modules adoption is moving fairly quickly imo :)

@jessewgibbs
Copy link

@fgblomqvist thanks for the contribution.

@rokob can you review when you get a chance?

@rokob
Copy link
Contributor

rokob commented Feb 20, 2019

Yeah LGTM

@rokob rokob merged commit 8802370 into rollbar:master Feb 20, 2019
@fgblomqvist fgblomqvist deleted the feature/make-go-module branch June 11, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants