Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed default IP Address, removed the port #94

Merged
merged 2 commits into from
Jun 14, 2022
Merged

fixed default IP Address, removed the port #94

merged 2 commits into from
Jun 14, 2022

Conversation

pawelsz-rb
Copy link
Collaborator

@pawelsz-rb pawelsz-rb commented Jun 13, 2022 •
edited
Loading

Description of the change

fixed default IP Address in the request, removed the port
This fix was needed to be compatible with what our front-end expects.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@pawelsz-rb pawelsz-rb requested a review from nieblara June 13, 2022 19:02
ijsnow
ijsnow approved these changes Jun 13, 2022
View reviewed changes
Copy link

@ijsnow ijsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple

@pawelsz-rb pawelsz-rb merged commit 0066903 into master Jun 14, 2022
@pawelsz-rb pawelsz-rb deleted the pawel/fix_ip_address branch June 14, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijsnow ijsnow ijsnow approved these changes

@nieblara nieblara Awaiting requested review from nieblara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelsz-rb @ijsnow