Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saving of email and managing email connection #2378

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

aaliakseyenka
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

🔗 Related issue link

#2345

💡 Background and solution

There was a migration to new profile API, which broke the email saving

Copy link

github-actions bot commented Nov 26, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 110.94 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/ 291.6 KB 402.54 KB 80.51% (🟢 -0.01%)
/404 226.72 KB 337.66 KB 67.53% (🟢 -0.01%)
/admin/courses 386.77 KB 497.71 KB 99.54% (🟢 -0.01%)
/admin/disciplines 332.29 KB 443.22 KB 88.64% (+/- <0.01%)
/admin/discord-server 358.83 KB 469.77 KB 93.95% (🟢 -0.01%)
/admin/events 359.43 KB 470.37 KB 94.07% (🟢 -0.01%)
/admin/mentor-registry 382.69 KB 493.63 KB 98.73% (🟢 -0.01%)
/admin/notifications 397.68 KB 508.62 KB 101.72% (🟢 -0.01%)
/admin/prompts 339.55 KB 450.49 KB 90.10% (🟢 -0.01%)
/admin/registrations 331.07 KB 442.01 KB 88.40% (🟢 -0.01%)
/admin/tasks 440.08 KB 551.02 KB 110.20% (🟢 -0.01%)
/admin/user-group 382.75 KB 493.68 KB 98.74% (🟢 -0.01%)
/admin/users 274.37 KB 385.31 KB 77.06% (🟢 -0.01%)
/applicants 314.42 KB 425.36 KB 85.07% (🟢 -0.01%)
/course/admin/cross-check-table 435.72 KB 546.66 KB 109.33% (🟢 -0.01%)
/course/admin/events 440.34 KB 551.28 KB 110.26% (🟢 -0.01%)
/course/admin/interviews 381.55 KB 492.49 KB 98.50% (🟢 -0.01%)
/course/admin/mentors 386.16 KB 497.1 KB 99.42% (🟢 -0.01%)
/course/admin/stage-interviews 383.13 KB 494.07 KB 98.81% (+/- <0.01%)
/course/admin/students 394.09 KB 505.03 KB 101.01% (🟢 -0.01%)
/course/admin/tasks 414.1 KB 525.04 KB 105.01% (🟢 -0.01%)
/course/admin/users 381.58 KB 492.52 KB 98.50% (🟢 -0.01%)
/course/interview/[type]/feedback 345.81 KB 456.75 KB 91.35% (🟢 -0.01%)
/course/mentor/auto-confirm 228.89 KB 339.83 KB 67.97% (🟢 -0.01%)
/course/mentor/confirm 295.26 KB 406.2 KB 81.24% (🟢 -0.01%)
/course/mentor/dashboard 402.59 KB 513.53 KB 102.71% (🟢 -0.01%)
/course/mentor/expel-student 299.27 KB 410.21 KB 82.04% (🟢 -0.01%)
/course/mentor/feedback 301.39 KB 412.32 KB 82.46% (+/- <0.01%)
/course/mentor/interview-technical-screening 267.8 KB 378.74 KB 75.75% (🟢 -0.01%)
/course/mentor/interview-wait-list 340.12 KB 451.06 KB 90.21% (🟢 -0.01%)
/course/mentor/interviews 350.97 KB 461.91 KB 92.38% (🟢 -0.01%)
/course/mentor/students 251.74 KB 362.68 KB 72.54% (🟢 -0.01%)
/course/schedule 482.26 KB 593.2 KB 118.64% (🟢 -0.01%)
/course/score 340.24 KB 451.18 KB 90.24% (🟢 -0.01%)
/course/student/auto-test 392.91 KB 503.85 KB 100.77% (🟢 -0.01%)
/course/student/auto-test/task 392.83 KB 503.77 KB 100.75% (🟢 -0.01%)
/course/student/cross-check-review 416.66 KB 527.6 KB 105.52% (🟢 -0.01%)
/course/student/cross-check-submit 432.85 KB 543.79 KB 108.76% (🟢 -0.01%)
/course/student/dashboard 399.94 KB 510.88 KB 102.18% (🟢 -0.01%)
/course/student/interviews 305.04 KB 415.97 KB 83.19% (+/- <0.01%)
/course/submit-scores 415.43 KB 526.37 KB 105.27% (+/- <0.01%)
/course/team-distributions 383.89 KB 494.83 KB 98.97% (🟢 -0.01%)
/course/teams 430.09 KB 541.03 KB 108.21% (🟢 -0.01%)
/cv/[uuid] 246.29 KB 357.23 KB 71.45% (🟢 -0.01%)
/cv/edit 350.22 KB 461.15 KB 92.23% (🟢 -0.01%)
/gratitude 293.84 KB 404.78 KB 80.96% (🟢 -0.01%)
/heroes 399.62 KB 510.56 KB 102.11% (🟢 -0.01%)
/job 171.36 KB 282.3 KB 56.46% (🟢 -0.01%)
/profile 410.26 KB 521.2 KB 104.24% (🟢 -0.01%)
/profile/connection-confirmed 268.01 KB 378.95 KB 75.79% (🟢 -0.01%)
/profile/notifications 332.51 KB 443.45 KB 88.69% (🟢 -0.01%)
/registry/epamlearningjs 294.81 KB 405.74 KB 81.15% (🟢 -0.01%)
/registry/mentor 345.24 KB 456.18 KB 91.24% (🟢 -0.01%)
/registry/student 345.23 KB 456.17 KB 91.23% (🟢 -0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@valerydluski
Copy link
Contributor

Great job, the best code is the deleted code

@aaliakseyenka aaliakseyenka merged commit 0054a50 into master Nov 28, 2023
6 checks passed
@aaliakseyenka aaliakseyenka deleted the email-confirmation branch November 28, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants