-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Import #1
Conversation
090a2da
to
003ba5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good, apart from a bit of a change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also include this in the golangci
linters-settings:
revive:
rules:
- name: exported
arguments:
- disableStutteringCheck
issues:
include:
- EXC0012 # EXC0012 revive: Annoying issue about not having a comment. The rare codebase has such comments
- EXC0014 # EXC0014 revive: Annoying issue about not having a comment. The rare codebase has such comments
ref: rollkit/rollkit#587
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the validate parameter being ID instead of Commitment
Currently, our Submit function is async in Rollkit. An option to do that here would be to decouple the inclusion proof generation from the response of the submission. The flow could be Submit -> get commitment as a response ( can be generated deterministically) and would be an instant response This would be the current interaction with celestias blob module. Either way, I think we should merge this and then make changes afterwards , as is does not have to be perfect from the start and we can expect to break the API. |
d1935ef
to
09be967
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
Overview
This PR consists of initial CI configuration, DA interface definition, dummy DA implementation and unit tests.
Resolves #2
Resolves #3
Resolves #4
Checklist