Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Import #1

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Initial Import #1

merged 9 commits into from
Sep 25, 2023

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Sep 18, 2023

Overview

This PR consists of initial CI configuration, DA interface definition, dummy DA implementation and unit tests.

Resolves #2
Resolves #3
Resolves #4

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tzdybal tzdybal changed the title chore: initial repository configuration Initial Import Sep 18, 2023
@tzdybal tzdybal self-assigned this Sep 18, 2023
@tzdybal tzdybal marked this pull request as ready for review September 18, 2023 19:41
@tzdybal tzdybal mentioned this pull request Sep 18, 2023
@tzdybal tzdybal enabled auto-merge (squash) September 19, 2023 08:48
Copy link
Member

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good, apart from a bit of a change

da.go Outdated Show resolved Hide resolved
da.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also include this in the golangci

linters-settings:
  revive:
    rules:
      - name: exported
        arguments:
          - disableStutteringCheck

issues:
  include:
    - EXC0012  # EXC0012 revive: Annoying issue about not having a comment. The rare codebase has such comments
    - EXC0014  # EXC0014 revive: Annoying issue about not having a comment. The rare codebase has such comments

ref: rollkit/rollkit#587

Copy link
Member

@gupadhyaya gupadhyaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the validate parameter being ID instead of Commitment

@nashqueue
Copy link
Member

Currently, our Submit function is async in Rollkit. An option to do that here would be to decouple the inclusion proof generation from the response of the submission.

The flow could be Submit -> get commitment as a response ( can be generated deterministically) and would be an instant response
Then something like getProof(ID) to get the proof which might happen Blocks (minutes) into the future

This would be the current interaction with celestias blob module.

Either way, I think we should merge this and then make changes afterwards , as is does not have to be perfect from the start and we can expect to break the API.

Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@tzdybal tzdybal merged commit 97dc8db into main Sep 25, 2023
1 check passed
@tzdybal tzdybal deleted the tzdybal/initial_repo branch September 25, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dummy DA implementation for tests Initial code of DA interface Setup go-da repository
5 participants