fix(rome_js_analyzer): Big pack of js/ts files that crashes rome #4323

CHANGELOG.md

@@ -32,6 +32,8 @@
 ### Formatter
 ### Linter
 
+- Fix a crash in the `NoParameterAssign` rule that occurred when there was a bogus binding. [#4323](https://github.com/rome/tools/issues/4323)
+
 #### Other changes
 
 - The rules [`useExhaustiveDependencies`](https://docs.rome.tools/lint/rules/useexhaustivedependencies/) and [`useHookAtTopLevel`](https://docs.rome.tools/lint/rules/usehookattoplevel/) accept a different

crates/rome_cli/tests/commands/check.rs

@@ -2274,6 +2274,38 @@ if (true) {
     ));
 }
 
+#[test]
+fn apply_bogus_argument() {
+    let mut fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    let file_path = Path::new("fix.js");
+    fs.insert(
+        file_path.into(),
+        "function _13_1_3_fun(arguments) { }".as_bytes(),
+    );
+
+    let result = run_cli(
+        DynRef::Borrowed(&mut fs),
+        &mut console,
+        Args::from(&[
+            ("check"),
+            file_path.as_os_str().to_str().unwrap(),
+            ("--apply-unsafe"),
+        ]),
+    );
+
+    assert!(result.is_ok(), "run_cli returned {result:?}");
+
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "apply_bogus_argument",
+        fs,
+        console,
+        result,
+    ));
+}
+
 #[test]
 fn ignores_unknown_file() {
     let mut fs = MemoryFileSystem::default();

crates/rome_cli/tests/snapshots/main_commands_check/apply_bogus_argument.snap

@@ -0,0 +1,18 @@
+---
+source: crates/rome_cli/tests/snap_test.rs
+expression: content
+---
+## `fix.js`
+
+```js
+function _13_1_3_fun(arguments) { }
+
+```
+
+# Emitted Messages
+
+```block
+Fixed 1 file(s) in <TIME>
+```
+
+

crates/rome_js_analyze/src/semantic_analyzers/style/no_parameter_assign.rs

@@ -2,7 +2,7 @@ use crate::semantic_services::Semantic;
 use rome_analyze::{context::RuleContext, declare_rule, Rule, RuleDiagnostic};
 use rome_console::markup;
 use rome_js_semantic::{AllBindingWriteReferencesIter, Reference, ReferencesExtensions};
-use rome_js_syntax::{AnyJsBindingPattern, AnyJsFormalParameter, AnyJsParameter};
+use rome_js_syntax::{AnyJsBinding, AnyJsBindingPattern, AnyJsFormalParameter, AnyJsParameter};
 use rome_rowan::AstNode;
 
 declare_rule! {
@@ -71,10 +71,10 @@ impl Rule for NoParameterAssign {
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
         let param = ctx.query();
         let model = ctx.model();
-        if let Some(binding) = binding_of(param) {
-            if let Some(binding) = binding.as_any_js_binding() {
-                return binding.all_writes(model);
-            }
+        if let Some(AnyJsBindingPattern::AnyJsBinding(AnyJsBinding::JsIdentifierBinding(binding))) =
+            binding_of(param)
+        {
+            return binding.all_writes(model);
         }
         // Empty iterator that conforms to `AllBindingWriteReferencesIter` type.
         std::iter::successors(None, |_| None)

crates/rome_js_analyze/tests/specs/style/noParameterAssign/valid.jsonc

@@ -57,5 +57,6 @@
 	"function foo(a) { for ([a.b] of []); }",
 	"function foo(a) { a.b &&= c; }",
 	"function foo(a) { a.b.c ||= d; }",
-	"function foo(a) { a[b] ??= c; }"
+	"function foo(a) { a[b] ??= c; }",
+	"function foo(arguments) { }"
 ]

crates/rome_js_analyze/tests/specs/style/noParameterAssign/valid.jsonc.snap

@@ -1,6 +1,5 @@
 ---
 source: crates/rome_js_analyze/tests/spec_tests.rs
-assertion_line: 91
 expression: valid.jsonc
 ---
 # Input
@@ -298,4 +297,9 @@ function foo(a) { a.b.c ||= d; }
 function foo(a) { a[b] ??= c; }
 ```
 
+# Input
+```js
+function foo(arguments) { }
+```
+
 

crates/rome_js_semantic/src/semantic_model/binding.rs

@@ -1,7 +1,5 @@
 use super::*;
-use rome_js_syntax::{
-    binding_ext::AnyJsIdentifierBinding, AnyJsBinding, TextRange, TsTypeParameterName,
-};
+use rome_js_syntax::{binding_ext::AnyJsIdentifierBinding, TextRange, TsTypeParameterName};
 
 /// Internal type with all the semantic data of a specific binding
 #[derive(Debug)]
@@ -135,7 +133,6 @@ pub trait IsBindingAstNode: AstNode<Language = JsLanguage> {
 impl IsBindingAstNode for JsIdentifierBinding {}
 impl IsBindingAstNode for TsIdentifierBinding {}
 impl IsBindingAstNode for AnyJsIdentifierBinding {}
-impl IsBindingAstNode for AnyJsBinding {}
 impl IsBindingAstNode for TsTypeParameterName {}
 
 /// Extension method to allow nodes that have declaration to easily

crates/rome_js_semantic/src/semantic_model/model.rs

@@ -373,7 +373,7 @@ impl SemanticModel {
         };
 
         Some(AllCallsIter {
-            references: identifier.all_reads(self),
+            references: identifier.as_js_identifier_binding()?.all_reads(self),
         })
     }
 }