Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default value for github-token input. #22

Merged
merged 5 commits into from
Jun 1, 2021

Conversation

jackton1
Copy link

@jackton1 jackton1 commented May 7, 2021

Purpose

Allow users to skip redeclaring the default repo token each time.

This would now be required only when the token is different i.e Using a Personal Access Token.

@romeovs

Copy link

@the-homeless-god the-homeless-god left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you define reasons?

@jackton1
Copy link
Author

@Zimtir ⬆️

@jackton1
Copy link
Author

@Zimtir Any blockers on getting a new version ??

@the-homeless-god
Copy link

@jackton1 I beleive @romeovs as owner can resolve it

README.md Outdated Show resolved Hide resolved
@@ -8,6 +8,7 @@ inputs:
github-token:
description: Github token
required: true
default: ${{ github.token }}
Copy link
Owner

@romeovs romeovs Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you point me to some documentation on github.token. I haven't been able to find anything.

Never mind, found the docs

@romeovs romeovs merged commit a1c0d02 into romeovs:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants