Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document nested block comments and add more intra docs links #440

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Mar 13, 2023

Fixes #439 and helps with #377.

* [ ] I've included my change in CHANGELOG.md

@juntyr
Copy link
Member Author

juntyr commented Mar 13, 2023

@ModProg could you perhaps take a look at the grammar changes - it's unfortunately been a while since I last wrote some EBNF :)

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +3.12 🎉

Comparison is base (d15bacc) 84.52% compared to head (439b246) 87.64%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   84.52%   87.64%   +3.12%     
==========================================
  Files          59       59              
  Lines        7470     7204     -266     
==========================================
  Hits         6314     6314              
+ Misses       1156      890     -266     
Impacted Files Coverage Δ
src/de/mod.rs 76.92% <0.00%> (+6.35%) ⬆️
src/options.rs 49.57% <0.00%> (+6.28%) ⬆️
src/parse.rs 92.39% <ø> (+19.69%) ⬆️
src/ser/mod.rs 72.70% <0.00%> (+2.02%) ⬆️
src/value/mod.rs 55.87% <0.00%> (-11.61%) ⬇️
src/value/raw.rs 88.65% <0.00%> (-11.35%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/grammar.md Outdated Show resolved Hide resolved
Co-authored-by: Roland Fredenhagen <dev@modprog.de>
@juntyr juntyr merged commit 66ccded into ron-rs:master Mar 13, 2023
@juntyr juntyr deleted the docs-improvements branch March 13, 2023 11:36
juntyr added a commit to juntyr/ron that referenced this pull request Aug 15, 2023
juntyr added a commit to juntyr/ron that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document nested doc comments in grammar
3 participants