-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depend on serde_derive
separately for more compilation parallelism
#441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thank you!
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 84.52% 86.73% +2.20%
==========================================
Files 59 59
Lines 7470 7280 -190
==========================================
Hits 6314 6314
+ Misses 1156 966 -190
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I’ll review later tonight after dinner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on-rs#441) * depend on serde_derive separately for more compilation parallelism * add changelog entry
CHANGELOG.md
If no crate enables the
derive
feature ofserde
, thenserde
andserde_derive
can compile in parallel, and anything depending only onserde
can compile whileserde_derive
is not yet done.This can save up to 5 seconds of compilation, depending on whether this helps the critical chain and if no other crate enables the feature.