Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde attributes limitations to README.md #450

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Add serde attributes limitations to README.md #450

merged 1 commit into from
Apr 19, 2023

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Apr 19, 2023

* [ ] I've included my change in CHANGELOG.md

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (2a57149) 86.65% compared to head (7475bae) 86.63%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   86.65%   86.63%   -0.02%     
==========================================
  Files          60       60              
  Lines        7364     7364              
==========================================
- Hits         6381     6380       -1     
- Misses        983      984       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GoldsteinE
Copy link

Side note: is README.md included in coverage?..

@juntyr
Copy link
Member Author

juntyr commented Apr 19, 2023

Side note: is README.md included in coverage?..

Yes, indirectly, since we're generating the crate doc comment based on the README

@juntyr juntyr merged commit 484fcab into master Apr 19, 2023
@juntyr juntyr deleted the limitations branch April 19, 2023 12:51
juntyr added a commit to juntyr/ron that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants