Fixes + More Metrics #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een hacking in my branch. Note: this is not complete. I have not run the code yet, I am sure there are bugs that need to be fixed.
|
@robertgshaw2-neuralmagic can I pick it up from here? |
|
The current state is that ~half of this PR is merged into upstream main so big next steps are rebasing this branch onto current upstream main and making sure all the metrics are being computed correctly |
|
@robertgshaw2-neuralmagic when I rebase my branch to what should I do then? I think I should create a new branch from |
|
Yeah I would make a new branch, just replicating the new metrics that were added here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statsto have the_suffixpatternNOTE: this code does not run. I have not finished debugging it.
Could you pick it up from here @ronensc ?