Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_forecast_towns doesn't apply distance_km parameter #35

Closed
nwbort opened this issue Jul 28, 2023 · 1 comment
Closed

find_forecast_towns doesn't apply distance_km parameter #35

nwbort opened this issue Jul 28, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nwbort
Copy link

nwbort commented Jul 28, 2023

Describe the bug

find_forecast_towns returns the same results regardless of the value of the distance_km parameter.

To Reproduce

Execute:

library(weatherOz)
find_forecast_towns(longitude = 149.2, latitude = -35.3, distance_km = 100)

Actual behaviour:
A data.table with 1475 rows, including forecast towns further away from the point than 100km.

Expected behavior
Return data.table with 24 rows, being the forecast towns no further away than 100km from the point.

Desktop:

  • Version: weatherOz_0.0.1
  • OS: Windows 11
@adamhsparks adamhsparks added the bug Something isn't working label Jul 28, 2023
@adamhsparks adamhsparks self-assigned this Jul 28, 2023
adamhsparks pushed a commit that referenced this issue Jul 28, 2023
@adamhsparks
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants