Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum version of rosdistro to support rosdistro index v4. #493

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

nuclearsandwich
Copy link
Contributor

For now we don't make any use of the new distribution data in index v4.
This is a minimal update to fix failures with bloom due to the version
restrictions.

This PR has been tested locally.

For now we don't make any use of the new distribution data in index v4.
This is a minimal update to fix failures with bloom due to the version
restrictions.
@dirk-thomas
Copy link
Member

What is the reason to require the new rosdistro version?

@nuclearsandwich
Copy link
Contributor Author

What is the reason to require the new rosdistro version?

If we're going to support the index v4 we should require a rosdistro index version that also supports it.

@dirk-thomas
Copy link
Member

If we're going to support the index v4 we should require a rosdistro index version that also supports it.

I don't understand the rational here. In the original description you explicitly stated:

For now we don't make any use of the new distribution data in index v4.
This is a minimal update to fix failures with bloom due to the version restrictions.

@nuclearsandwich
Copy link
Contributor Author

I don't understand the rational here. In the original description you explicitly stated:

We're not making explicit use of the v4 data but that doesn't mean bloom won't attempt to parse the v4 file and raise an error if the version of rosdep is not able to parse it.

This was an ASAP release per your request and I think bumping the required rosdistro version is a reasonable thing to do to avoid future "gotchas" where bloom is updated but rosdistro is not.

If you would like to test an alternative change against rosdep 0.4.0 and verify it you're welcome to do so but please be cognizant of the QA work that gets put into bloom releases rather than assuming that changing a 3 to a 4 and hoping that CI passes is sufficient to avoid issues popping up after release.

@dirk-thomas
Copy link
Member

that doesn't mean bloom won't attempt to parse the v4 file and raise an error if the version of rosdep is not able to parse it.

avoid future "gotchas" where bloom is updated but rosdistro is not.

assuming that changing a 3 to a 4 and hoping that CI passes is sufficient to avoid issues popping up after release.

With the changes in v4 in mind I don't see any technical possibility how that should result in incompatibilities. If you do please describe in which concrete scenario that would the case.

Anyway I will this up to you to decide if you want to bump the version dependency anyway.

Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind one way or the other, it's not a bad thing to drag people to the new version of rosdistro anyways.

Changes lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants