Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally supress sudo rosdep update warning with flag #915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ijnek
Copy link
Member

@ijnek ijnek commented Feb 23, 2023

This adds a flag to simply supress the warning if a user wants to.
It seems better than telling everyone to ignore the warning if using docker (which is often root).

Resolves: #473

Signed-off-by: ijnek <kenjibrameld@gmail.com>
@ijnek
Copy link
Member Author

ijnek commented Feb 23, 2023

Mac OS CI failing due to #912

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (b6ad189) 74.83% compared to head (7150bba) 74.84%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #915   +/-   ##
=======================================
  Coverage   74.83%   74.84%           
=======================================
  Files          44       44           
  Lines        3362     3363    +1     
=======================================
+ Hits         2516     2517    +1     
  Misses        846      846           
Impacted Files Coverage Δ
src/rosdep2/main.py 48.70% <50.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sudo and rosdep
2 participants