Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "openeuler" support to os_detect.py #260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Z572
Copy link

@Z572 Z572 commented Apr 24, 2023

return os.path.exists(self._release_file)
def get_version(self):
if self.is_os():
return self._release_info["VERSION_ID"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating this to prevent the KeyError from raising if the release file doesn't contain VERSION_ID?

I don't have any strong feelings about how to handle the lack of VERSION_ID, but a KeyError isn't very actionable. I think either returning an empty string or raising OsNotDetected would probably be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants