-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Problem 1 as discussed #3
Conversation
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Two blocking comments:
-
You don't need to define two identical table categories in the metadata YAML file, as they are the same. You can just have a single
table
and create 2 instances in the Python file as you have done. -
For the
docker compose
volume mounts to work correctly, you need to move thedelib_ws_p1
folder into thesrc
folder of the repo. With this change, I can enter the container and runcolcon build
, and the new package will actually be there to be build.
After making fix 2 above, I was able to build and run the example in the container!
I did find that the nav pose was wrong for the table, as seen here:
After digging, I found a small bug on my end and it is now fixed: sea-bass/pyrobosim#201
Also, it seems those CI jobs that were added in this PR have been queued for the last 6 hours... maybe it's just a retry, maybe something else? |
This is because I had to make the repo private. |
|
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Right, you can still do this! Just pass in
We can! Just have to change the mount locations in the roscon24-workshop/docker-compose.yaml Line 37 in 4e535f7
|
No description provided.