Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Problem 1 as discussed #3

Merged
merged 9 commits into from
Jul 14, 2024
Merged

Adding Problem 1 as discussed #3

merged 9 commits into from
Jul 14, 2024

Conversation

ct2034
Copy link
Contributor

@ct2034 ct2034 commented Jul 10, 2024

No description provided.

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 ct2034 requested a review from sea-bass July 10, 2024 19:45
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Copy link
Collaborator

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Two blocking comments:

  1. You don't need to define two identical table categories in the metadata YAML file, as they are the same. You can just have a single table and create 2 instances in the Python file as you have done.

  2. For the docker compose volume mounts to work correctly, you need to move the delib_ws_p1 folder into the src folder of the repo. With this change, I can enter the container and run colcon build, and the new package will actually be there to be build.

After making fix 2 above, I was able to build and run the example in the container!

image


I did find that the nav pose was wrong for the table, as seen here:

image

After digging, I found a small bug on my end and it is now fixed: sea-bass/pyrobosim#201

delib_ws_p1/LICENSE Outdated Show resolved Hide resolved
delib_ws_p1/data/location_data.yaml Outdated Show resolved Hide resolved
delib_ws_p1/delib_ws_p1/run.py Outdated Show resolved Hide resolved
delib_ws_p1/delib_ws_p1/run.py Show resolved Hide resolved
@sea-bass
Copy link
Collaborator

Also, it seems those CI jobs that were added in this PR have been queued for the last 6 hours... maybe it's just a retry, maybe something else?

delib_ws_p1/delib_ws_p1/run.py Outdated Show resolved Hide resolved
delib_ws_p1/delib_ws_p1/run.py Outdated Show resolved Hide resolved
@ct2034
Copy link
Contributor Author

ct2034 commented Jul 11, 2024

Also, it seems those CI jobs that were added in this PR have been queued for the last 6 hours... maybe it's just a retry, maybe something else?

This is because I had to make the repo private.

@ct2034
Copy link
Contributor Author

ct2034 commented Jul 14, 2024

  • You don't need to define two identical table categories in the metadata YAML file, as they are the same. You can just have a single table and create 2 instances in the Python file as you have done.
  1. The two tables have different colors ;-) But, I guess this does not make a big difference.

  2. Usually in ROS repos, the packages are on the top-level. Do you think we could change the Docker workflow this way?

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 ct2034 requested a review from sea-bass July 14, 2024 09:42
@sea-bass
Copy link
Collaborator

sea-bass commented Jul 14, 2024

  1. The two tables have different colors ;-) But, I guess this does not make a big difference.

Right, you can still do this! Just pass in color=(R, G B) in the constructor of each instance and it will override the category level color... or the same in your call to world.add_location(...)

  1. Usually in ROS repos, the packages are on the top-level. Do you think we could change the Docker workflow this way?

We can! Just have to change the mount locations in the docker_compose.yaml file.

- ./src:/delib_ws/src/workshop_files:rw

@ct2034 ct2034 merged commit 94d335c into main Jul 14, 2024
1 of 3 checks passed
@ct2034 ct2034 deleted the add/problem_1 branch July 14, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants