Update Rust toolchain to 1.71.0 and remove pydocstyle workaround #321
Conversation
|
@maspe36 I used the workaround I suggested in #320 (comment) and it seems to build fine locally. Let me know if you prefer the changes in PR to be split into separate PRs, I think it'd be cleaner, but given that I was already fixing |
There was a problem hiding this comment.
The Dockerfile also has a reference to rust 1.63 that should probably be upgraded to 1.70
| @@ -404,6 +404,7 @@ pub mod rmw { | |||
| pub description: rosidl_runtime_rs::String, | |||
| pub additional_constraints: rosidl_runtime_rs::String, | |||
| pub read_only: bool, | |||
| pub dynamic_typing: bool, | |||
There was a problem hiding this comment.
Does this break backwards compatibility with humble?
There was a problem hiding this comment.
Humble does have a dynamic_typing field as well (https://github.com/ros2/rcl_interfaces/blob/humble/rcl_interfaces/msg/ParameterDescriptor.msg#L25), so this should be ok.
esteve
changed the title
Done. I updated it to 1.71.0, which was released yesterday. |
|
@maspe36 thanks for reviewing these changes 🙂 |
No description provided.